Display off is done by a callback into backlight controller

Display off is done by a callback into backlight controller

Previously, backlight controller turned off the display after backlight
was turned off by using a polling event to wait for the backlight to
turn off.  But the polling loop caused problems.

This patch replaces the polling loop with a callback.  When the timeout
event that finally sets backlight to zero is triggered, it will invoke
the callback to determine whether the display should be turned off,
based on the power state.

BUG=chromium-os:13327
TEST=In /var/lib/power_manager, set [un]plugged_dim_ms to 30000 and
[un]plugged_off_ms to 60000.  Restart powerd.  Wait for 60 seconds.  The
display should turn off.

Change-Id: Ica4a1cc5708f28320607515e891f8aeee6831922
Signed-off-by: Simon Que <sque@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5ae2cf3

[Benson Leung, 2011-03-21 23:45:16]

http://codereview.chromium.org/6715014/diff/1/backlight.cc
File backlight.cc (right):

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode6
backlight.cc:6: #include "power_manager/backlight_controller.h"
Do you need backlight_controller.h?

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode9
backlight.cc:9: #include <gdk/gdkx.h>
I don't think there is any gdk requirement here?

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode14
backlight.cc:14: #include <X11/extensions/dpms.h>
Are you calling dpms from here?

http://codereview.chromium.org/6715014/diff/1/backlight.h
File backlight.h (right):

http://codereview.chromium.org/6715014/diff/1/backlight.h#newcode49
backlight.h:49: 
Extra line.

[Simon Que, 2011-03-22 22:08:27]

PTAL

http://codereview.chromium.org/6715014/diff/1/backlight.cc
File backlight.cc (right):

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode6
backlight.cc:6: #include "power_manager/backlight_controller.h"
On 2011/03/21 23:45:16, Benson Leung wrote:
> Do you need backlight_controller.h?

Done.

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode9
backlight.cc:9: #include <gdk/gdkx.h>
On 2011/03/21 23:45:16, Benson Leung wrote:
> I don't think there is any gdk requirement here?

Done.

http://codereview.chromium.org/6715014/diff/1/backlight.cc#newcode14
backlight.cc:14: #include <X11/extensions/dpms.h>
On 2011/03/21 23:45:16, Benson Leung wrote:
> Are you calling dpms from here?

Done.

http://codereview.chromium.org/6715014/diff/1/backlight.h
File backlight.h (right):

http://codereview.chromium.org/6715014/diff/1/backlight.h#newcode49
backlight.h:49: 
On 2011/03/21 23:45:16, Benson Leung wrote:
> Extra line.

Done.

http://codereview.chromium.org/6715014/diff/4001/mock_backlight.h
File mock_backlight.h (right):

http://codereview.chromium.org/6715014/diff/4001/mock_backlight.h#newcode1
mock_backlight.h:1: // Copyright (c) 2011 The Chromium OS Authors. All rights
reserved.
Fixed.

[Benson Leung, 2011-03-23 03:04:54]

Looks good to me.