Non-SFI mode: build latency_info_nacl library for nacl_helper_nonsfi.

Non-SFI mode: build latency_info_nacl library for nacl_helper_nonsfi.

liblatency_info_nacl.a will be used by libppapi for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.
It will be depended on by ppapi_proxy_nacl in a later CL.

BUG=358465
TEST=Ran trybot.

Committed: https://crrev.com/7b8a42ab6e53565efbf3531ec48a2abae7b6c415
Cr-Commit-Position: refs/heads/master@{#301320}

[hidehiko, 2014-10-24 05:51:30]

hidehiko@chromium.org changed reviewers:
+ mseaborn@chromium.org, sadrul@chromium.org

[hidehiko, 2014-10-24 05:51:31]

sadrul@, could you review latency_info_nacl.gyp as an OWNER?
mseaborn@, could you review this from the project point of view?

Thank you for your review in advance,
- hidehiko

[sadrul, 2014-10-24 14:46:37]

sadrul@chromium.org changed reviewers:
+ miletus@chromium.org
- sadrul@chromium.org

[sadrul, 2014-10-24 14:47:01]

sadrul@ --> miletus@

[Mark Seaborn, 2014-10-24 18:08:15]

LGTM, though:  How many more of these per-library Gyp-only changes do you have,
Hidehiko?  If there's a lot more of them, would it make sense to combine them
into a single review, instead of doing 1 review per library?

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl.gyp
File ui/events/latency_info_nacl.gyp (right):

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl....
ui/events/latency_info_nacl.gyp:22: '../../base/base_nacl.gyp:base_nacl',
Same comment about dependencies as for
https://codereview.chromium.org/650593003/

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl....
ui/events/latency_info_nacl.gyp:34: 'build_pnacl_newlib': 0,
Same comment about checking this as for
https://codereview.chromium.org/650593003/

[Yufeng Shen (Slow to review), 2014-10-24 18:28:44]

lgtm

[hidehiko, 2014-10-27 06:09:16]

Thank you for review. Submitting...

Mark, I have one more remaining update CL for gyp, which is for PPAPI. (In more
precise, not GYP only, but with some small #ifdef editing).

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl.gyp
File ui/events/latency_info_nacl.gyp (right):

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl....
ui/events/latency_info_nacl.gyp:22: '../../base/base_nacl.gyp:base_nacl',
On 2014/10/24 18:08:15, Mark Seaborn wrote:
> Same comment about dependencies as for
> https://codereview.chromium.org/650593003/

Ditto. Please let me keep for circular dependency check and consistency.

https://codereview.chromium.org/671443005/diff/1/ui/events/latency_info_nacl....
ui/events/latency_info_nacl.gyp:34: 'build_pnacl_newlib': 0,
On 2014/10/24 18:08:15, Mark Seaborn wrote:
> Same comment about checking this as for
> https://codereview.chromium.org/650593003/

Yes, no one uses.

[hidehiko, 2014-10-27 06:09:37]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2014-10-27 06:10:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/671443005/20001

[commit-bot: I haz the power, 2014-10-27 06:52:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-27 06:53:14]

Patchset 2 (id:??) landed as
https://crrev.com/7b8a42ab6e53565efbf3531ec48a2abae7b6c415
Cr-Commit-Position: refs/heads/master@{#301320}