Issue 671443003: Fix nacl-atomic-fence-all test to have alignment specified in load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671443003: Fix nacl-atomic-fence-all test to have alignment specified in load. (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)

Modified:
6 years, 2 months ago

Reviewers:
kschimpf, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Fix nacl-atomic-fence-all test to have alignment specified in load. Helps make it work with p2i instead of lc2i. This affected the address mode optimizations, so some of the test expectations have changed. BUG=none (happened to notice it while trying to test some things manually) R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d8d67f4d2e5624afb3694d030cc33ee32e9859b1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -44 lines)			Patch
	M	tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll	View		11 chunks	+32 lines, -44 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

6 years, 2 months ago (2014-10-21 01:05:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d8d67f4d2e5624afb3694d030cc33ee32e9859b1 (presubmit successful).