Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 671433005: [chromedriver] Quit Chrome before cleaning up temporary directories (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, samuong+watch_chromium.org, stgao, andrewcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Quit Chrome before cleaning up temporary directories BUG= NOTRY=true TBR=stgao@chromium.org Committed: https://crrev.com/c76450400fcd81c0470e84010dcbd5215c6dc738 Cr-Commit-Position: refs/heads/master@{#300695}

Patch Set 1 #

Patch Set 2 : Also disable the tests on Android, since it's a desktop-only thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -46 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 2 chunks +52 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
samuong
The Windows builder is currently red because the Python tests are trying deleting the user ...
6 years, 2 months ago (2014-10-22 17:27:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671433005/20001
6 years, 2 months ago (2014-10-22 17:32:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 17:35:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:36:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c76450400fcd81c0470e84010dcbd5215c6dc738
Cr-Commit-Position: refs/heads/master@{#300695}

Powered by Google App Engine
This is Rietveld 408576698