Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 671433002: Convert fast/multicol/column-break-with-balancing (and related) to reftests. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/column-break-with-balancing (and related) to reftests. * Use standards mode. * Make test small enough to fit in content_shell. * Use fixed widths columns to simplify ref. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184184

Patch Set 1 #

Total comments: 9

Patch Set 2 : Use float, not inline-block. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -2153 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/column-break-with-balancing.html View 1 chunk +46 lines, -64 lines 0 comments Download
A LayoutTests/fast/multicol/column-break-with-balancing-expected.html View 1 1 chunk +54 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/column-break-with-balancing.html View 1 chunk +49 lines, -66 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/column-break-with-balancing-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/column-break-with-balancing.html View 1 chunk +49 lines, -64 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/column-break-with-balancing-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt View 1 chunk +0 lines, -163 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
andersr
6 years, 2 months ago (2014-10-20 13:25:44 UTC) #1
mstensho (USE GERRIT)
lgtm, but feel free to address the issues I raised (not a show-stopper, though). https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html ...
6 years, 2 months ago (2014-10-20 20:14:53 UTC) #2
andersr
https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html File LayoutTests/fast/multicol/column-break-with-balancing-expected.html (right): https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html#newcode10 LayoutTests/fast/multicol/column-break-with-balancing-expected.html:10: display: inline-block; On 2014/10/20 20:14:53, mstensho wrote: > You ...
6 years, 2 months ago (2014-10-21 07:00:11 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html File LayoutTests/fast/multicol/column-break-with-balancing-expected.html (right): https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html#newcode10 LayoutTests/fast/multicol/column-break-with-balancing-expected.html:10: display: inline-block; On 2014/10/21 07:00:11, andersr wrote: > On ...
6 years, 2 months ago (2014-10-21 07:35:09 UTC) #4
mstensho (USE GERRIT)
https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html File LayoutTests/fast/multicol/column-break-with-balancing-expected.html (right): https://codereview.chromium.org/671433002/diff/1/LayoutTests/fast/multicol/column-break-with-balancing-expected.html#newcode10 LayoutTests/fast/multicol/column-break-with-balancing-expected.html:10: display: inline-block; On 2014/10/21 07:00:11, andersr wrote: > On ...
6 years, 2 months ago (2014-10-21 07:35:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671433002/20001
6 years, 2 months ago (2014-10-21 09:04:16 UTC) #7
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-21 09:04:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671433002/20001
6 years, 2 months ago (2014-10-22 08:19:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33017)
6 years, 2 months ago (2014-10-22 10:24:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671433002/20001
6 years, 2 months ago (2014-10-22 10:49:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33052)
6 years, 2 months ago (2014-10-22 12:59:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671433002/20001
6 years, 2 months ago (2014-10-22 13:04:45 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 14:10:38 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184184

Powered by Google App Engine
This is Rietveld 408576698