test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc - Issue 671393002: [x86] Fix register constraints for multiply-high.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

Issue 671393002: [x86] Fix register constraints for multiply-high. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added regression test. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

diff --git a/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc b/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

index 2ce7bca708d56dc8ec4539d1c2e9d953b4efdacc..d1a17260a21e3a67e5e77fa9dd166f02622cc255 100644

--- a/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

+++ b/test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

@@ -593,9 +593,12 @@ TEST_F(InstructionSelectorTest, Int32MulHigh) {

EXPECT_EQ(kIA32ImulHigh, s[0]->arch_opcode());

ASSERT_EQ(2U, s[0]->InputCount());

EXPECT_EQ(s.ToVreg(p0), s.ToVreg(s[0]->InputAt(0)));

+ EXPECT_TRUE(s.IsFixed(s[0]->InputAt(0), eax));

EXPECT_EQ(s.ToVreg(p1), s.ToVreg(s[0]->InputAt(1)));

+ EXPECT_TRUE(!s.IsUsedAtStart(s[0]->InputAt(1)));

ASSERT_EQ(1U, s[0]->OutputCount());

EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));

+ EXPECT_TRUE(s.IsFixed(s[0]->OutputAt(0), edx));

}

} // namespace compiler