Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Issue 671393002: [x86] Fix register constraints for multiply-high. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
titzer, Toon Verwaest
CC:
titzer, v8-dev
Project:
v8
Visibility:
Public.

Description

[x86] Fix register constraints for multiply-high. TEST=mjsunit/compiler,unittests R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24862

Patch Set 1 #

Patch Set 2 : Added regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -7 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A test/mjsunit/compiler/regress-register-allocator.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Benedikt Meurer
PTAL Ben: FYI
6 years, 2 months ago (2014-10-24 05:29:28 UTC) #2
titzer
lgtm when we have a JS-level or machine-level repro. I hit this today; I have ...
6 years, 2 months ago (2014-10-24 08:28:14 UTC) #4
Benedikt Meurer
6 years, 2 months ago (2014-10-24 09:36:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698