Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/test/automation/automation_proxy.h

Issue 67139: Remove the usage of GetLastActiveBrowserWindow... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__ 5 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__
6 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__ 6 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Returns the BrowserProxy for the browser window at the given index, 121 // Returns the BrowserProxy for the browser window at the given index,
122 // transferring ownership of the pointer to the caller. 122 // transferring ownership of the pointer to the caller.
123 // On failure, returns NULL. 123 // On failure, returns NULL.
124 // 124 //
125 // Use GetBrowserWindowCount to see how many browser windows you can ask for. 125 // Use GetBrowserWindowCount to see how many browser windows you can ask for.
126 // Window numbers are 0-based. 126 // Window numbers are 0-based.
127 BrowserProxy* GetBrowserWindow(int window_index); 127 BrowserProxy* GetBrowserWindow(int window_index);
128 128
129 // Returns the BrowserProxy for the browser window which was last active, 129 // Returns the BrowserProxy for the browser window which was last active,
130 // transferring ownership of the pointer to the caller. 130 // transferring ownership of the pointer to the caller.
131 // If there was no last active browser window, or the last active browser 131 // TODO: If there was no last active browser window, or the last active
132 // window no longer exists (for example, if it was closed), returns 132 // browser window no longer exists (for example, if it was closed),
133 // GetBrowserWindow(0). 133 // returns GetBrowserWindow(0). See crbug.com/10501. As for now this
134 // function is flakey.
134 BrowserProxy* GetLastActiveBrowserWindow(); 135 BrowserProxy* GetLastActiveBrowserWindow();
135 136
136 // Returns the WindowProxy for the currently active window, transferring 137 // Returns the WindowProxy for the currently active window, transferring
137 // ownership of the pointer to the caller. 138 // ownership of the pointer to the caller.
138 // On failure, returns NULL. 139 // On failure, returns NULL.
139 WindowProxy* GetActiveWindow(); 140 WindowProxy* GetActiveWindow();
140 141
141 // Tells the browser to enable or disable network request filtering. Returns 142 // Tells the browser to enable or disable network request filtering. Returns
142 // false if the message fails to send to the browser. 143 // false if the message fails to send to the browser.
143 bool SetFilteredInet(bool enabled); 144 bool SetFilteredInet(bool enabled);
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 // a version resource. 240 // a version resource.
240 bool perform_version_check_; 241 bool perform_version_check_;
241 242
242 // Delay to let the browser execute the command. 243 // Delay to let the browser execute the command.
243 base::TimeDelta command_execution_timeout_; 244 base::TimeDelta command_execution_timeout_;
244 245
245 DISALLOW_COPY_AND_ASSIGN(AutomationProxy); 246 DISALLOW_COPY_AND_ASSIGN(AutomationProxy);
246 }; 247 };
247 248
248 #endif // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__ 249 #endif // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698