Issue 67139: Remove the usage of GetLastActiveBrowserWindow...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67139: Remove the usage of GetLastActiveBrowserWindow... (Closed)

Created:
11 years, 8 months ago by huanr

Modified:
9 years ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the usage of GetLastActiveBrowserWindow as the function is flakey. BUG=10501 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13709

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -26 lines)			Patch
M	chrome/browser/views/find_bar_win_interactive_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_base.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	5 chunks	+14 lines, -12 lines	2 comments	Download
M	chrome/test/automation/automation_proxy.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Finnur

http://codereview.chromium.org/67139/diff/1/3 File chrome/test/automated_ui_tests/automated_ui_tests.cc (right): http://codereview.chromium.org/67139/diff/1/3#newcode343 Line 343: set_active_browser(automation()->GetBrowserWindow(0)); Do you need a release_active_browser somewhere?

11 years, 8 months ago (2009-04-14 20:22:12 UTC) #2

huanr

11 years, 8 months ago (2009-04-14 20:58:26 UTC) #3

OK

Expand Messages | Collapse Messages