Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 671373002: Revert "Enabled the App Info dialog on the Extensions page by default" (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Enabled the App Info dialog on the Extensions page by default" The patch has caused compilation error again. TBR=sashab NOTREECHECK=true > This reverts commit 11778438dcb7670324f52e5df111e4007b9224ac. > > Enabled the App Info dialog on the Extensions page by default > > Changed the flag '--enable-extension-info-dialog' to > '--disable-extension-info-dialog', which enables the App Info dialog as > the default dialog for displaying permissions on the extensions page. > Does not affect Mac platforms (where the old-style dialog is still > used). > > BUG=395495 > Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0 > Cr-Commit-Position: refs/heads/master@{#301006} > > Committed: https://crrev.com/11778438dcb7670324f52e5df111e4007b9224ac > Cr-Commit-Position: refs/heads/master@{#301046} Committed: https://chromium.googlesource.com/chromium/src/+/b9f5c40b0e3252fe2ba8fe1ce8ee347f9e0b78ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -36 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/switches.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kouhei (in TOK)
6 years, 2 months ago (2014-10-24 04:26:15 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9f5c40b0e3252fe2ba8fe1ce8ee347f9e0b78ab Cr-Commit-Position: refs/heads/master@{#301047}
6 years, 2 months ago (2014-10-24 04:29:20 UTC) #3
kouhei (in TOK)
6 years, 2 months ago (2014-10-24 04:29:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9f5c40b0e3252fe2ba8fe1ce8ee347f9e0b78ab (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698