Issue 671353002: Fix Tab constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671353002: Fix Tab constructor (Closed)

Created:
6 years, 1 month ago by gone

Modified:
6 years, 1 month ago

Reviewers:
Ted C, David Trainor- moved to gerrit

CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix Tab constructor For some reason, the constructor arguments are flipped. Flip them so they make sense. BUG=415747 Committed: https://crrev.com/6aa5013ff32dae83905f9e466a1063858ae69982 Cr-Commit-Position: refs/heads/master@{#301146}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/Tab.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671353002/1

6 years, 1 month ago (2014-10-24 16:54:41 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-10-24 18:02:34 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6aa5013ff32dae83905f9e466a1063858ae69982
Cr-Commit-Position: refs/heads/master@{#301146}