chrome/browser/resources/hotword_audio_verification/flow.js - Issue 671333002: Hotword Audio Verification App: Fix window handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/hotword_audio_verification/flow.js

Issue 671333002: Hotword Audio Verification App: Fix window handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed blank line Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/hotword_audio_verification/event_page.js ('K') | « chrome/browser/resources/hotword_audio_verification/event_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/hotword_audio_verification/flow.js

diff --git a/chrome/browser/resources/hotword_audio_verification/flow.js b/chrome/browser/resources/hotword_audio_verification/flow.js

index 635456a06650e4a47640fa85cbcd4ad929572492..0ba06570fc18082d004a9d50ba5b00f7c3f9e6cd 100644

--- a/chrome/browser/resources/hotword_audio_verification/flow.js

+++ b/chrome/browser/resources/hotword_audio_verification/flow.js

@@ -73,6 +73,8 @@

Flow.prototype.showStep_ = function() {

var currentStep = this.currentFlow_[this.currentStepIndex_];

+ document.getElementById(currentStep).hidden = false;

var previousStep = null;

if (this.currentStepIndex_ > 0)

previousStep = this.currentFlow_[this.currentStepIndex_ - 1];

@@ -80,7 +82,7 @@

if (previousStep)

document.getElementById(previousStep).hidden = true;

- document.getElementById(currentStep).hidden = false;

+ chrome.app.window.current().show();

Dan Beam 2014/10/24 02:37:19 can current() return null or undefined?

Dan Beam 2014/10/27 15:53:38 ping

kcarattini 2014/10/27 22:59:19 Done.

};

window.Flow = Flow;