Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3196)

Unified Diff: chrome/browser/resources/hotword_audio_verification/event_page.js

Issue 671333002: Hotword Audio Verification App: Fix window handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Typo Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/hotword_audio_verification/flow.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/hotword_audio_verification/event_page.js
diff --git a/chrome/browser/resources/hotword_audio_verification/event_page.js b/chrome/browser/resources/hotword_audio_verification/event_page.js
index ad421b3430bc5d725b5212775a80c776ea145844..45d0d773820a47b2fc1abffb0ca6601ee937dcbc 100644
--- a/chrome/browser/resources/hotword_audio_verification/event_page.js
+++ b/chrome/browser/resources/hotword_audio_verification/event_page.js
@@ -2,15 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+var appId = 'hotword_audio_verification_app';
+
chrome.app.runtime.onLaunched.addListener(function() {
- // TODO(kcarattini): Check if the app is already running. If so, bring it
- // to focus rather than creating a new window.
+ // We need to focus the window if it already exists, since it
+ // is created as 'hidden'.
+ //
+ // Note: If we ever launch on another platform, make sure that this works
+ // with window managers that support hiding (e.g. Cmd+h on an app window on
+ // Mac).
+ var appWindow = chrome.app.window.get(appId);
+ if (appWindow) {
+ appWindow.focus();
+ return;
+ }
- // TODO(kcarattini): Don't show the window until the launch mode has been
- // established.
chrome.app.window.create('main.html', {
'frame': 'none',
'resizable': false,
+ 'hidden': true,
+ 'id': appId,
'bounds': {
'width': 800,
'height': 600
« no previous file with comments | « no previous file | chrome/browser/resources/hotword_audio_verification/flow.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698