Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/resources/hotword_audio_verification/flow.js

Issue 671333002: Hotword Audio Verification App: Fix window handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/hotword_audio_verification/flow.js
diff --git a/chrome/browser/resources/hotword_audio_verification/flow.js b/chrome/browser/resources/hotword_audio_verification/flow.js
index 635456a06650e4a47640fa85cbcd4ad929572492..55cdfc6e8ccbcb8a3cf46066cb43260e3d915fb6 100644
--- a/chrome/browser/resources/hotword_audio_verification/flow.js
+++ b/chrome/browser/resources/hotword_audio_verification/flow.js
@@ -73,6 +73,8 @@
*/
Flow.prototype.showStep_ = function() {
var currentStep = this.currentFlow_[this.currentStepIndex_];
+ document.getElementById(currentStep).hidden = false;
+
var previousStep = null;
if (this.currentStepIndex_ > 0)
previousStep = this.currentFlow_[this.currentStepIndex_ - 1];
@@ -80,7 +82,9 @@
if (previousStep)
document.getElementById(previousStep).hidden = true;
- document.getElementById(currentStep).hidden = false;
+ var appWindow = chrome.app.window.current();
+ if (appWindow)
Dan Beam 2014/10/27 23:13:20 this doesn't answer my question as I don't know wh
kcarattini 2014/10/27 23:24:12 There should always be an app window in this conte
Dan Beam 2014/10/27 23:29:20 then please leave the code as it was so we can cat
kcarattini 2014/10/27 23:57:20 Done. Sorry, I misunderstood your earlier question
+ appWindow.show();
};
window.Flow = Flow;

Powered by Google App Engine
This is Rietveld 408576698