Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/resources/hotword_audio_verification/event_page.js

Issue 671333002: Hotword Audio Verification App: Fix window handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debugging code Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/hotword_audio_verification/flow.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var appId = 'hotword_audio_verification_app';
6
5 chrome.app.runtime.onLaunched.addListener(function() { 7 chrome.app.runtime.onLaunched.addListener(function() {
6 // TODO(kcarattini): Check if the app is already running. If so, bring it 8 var appWindow = chrome.app.window.get(appId);
7 // to focus rather than creating a new window. 9 if (appWindow) {
10 appWindow.focus();
11 return;
12 }
Dan Beam 2014/10/24 00:31:48 seems like this should already happen[1]: """ If
kcarattini 2014/10/24 00:35:27 When I tested, the window did not focus, that's wh
kcarattini 2014/10/24 02:28:35 Issue https://code.google.com/p/chromium/issues/de
8 13
9 // TODO(kcarattini): Don't show the window until the launch mode has been
10 // established.
11 chrome.app.window.create('main.html', { 14 chrome.app.window.create('main.html', {
12 'frame': 'none', 15 'frame': 'none',
13 'resizable': false, 16 'resizable': false,
17 'hidden': true,
18 'id': appId,
14 'bounds': { 19 'bounds': {
15 'width': 800, 20 'width': 800,
16 'height': 600 21 'height': 600
17 } 22 }
18 }); 23 });
19 }); 24 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/hotword_audio_verification/flow.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698