Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: chrome/browser/resources/hotword_audio_verification/event_page.js

Issue 671333002: Hotword Audio Verification App: Fix window handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var appId = 'hotword_audio_verification_app';
6
5 chrome.app.runtime.onLaunched.addListener(function() { 7 chrome.app.runtime.onLaunched.addListener(function() {
6 // TODO(kcarattini): Check if the app is already running. If so, bring it 8 // We need to focus the window if it already exists, since it
7 // to focus rather than creating a new window. 9 // is created as 'hidden'.
10 var appWindow = chrome.app.window.get(appId);
Dan Beam 2014/10/27 23:13:20 what if this window is hidden? do we need to unhi
kcarattini 2014/10/27 23:24:12 The window is always shown very shortly after bein
Dan Beam 2014/10/27 23:29:20 does this work with window managers that support h
kcarattini 2014/10/27 23:57:20 Added a note, as discussed.
11 if (appWindow) {
12 appWindow.focus();
13 return;
14 }
8 15
9 // TODO(kcarattini): Don't show the window until the launch mode has been
10 // established.
11 chrome.app.window.create('main.html', { 16 chrome.app.window.create('main.html', {
12 'frame': 'none', 17 'frame': 'none',
13 'resizable': false, 18 'resizable': false,
19 'hidden': true,
Dan Beam 2014/10/27 23:13:20 why is this created hidden?
kcarattini 2014/10/27 23:24:12 I had a bug where the window would flash grey for
20 'id': appId,
14 'bounds': { 21 'bounds': {
15 'width': 800, 22 'width': 800,
16 'height': 600 23 'height': 600
17 } 24 }
18 }); 25 });
19 }); 26 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698