Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 671323002: Begin converting blink_skia_config from gyp to gypi. (Closed)

Created:
6 years, 2 months ago by bungeman-chromium
Modified:
6 years, 2 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Begin converting blink_skia_config from gyp to gypi. According to the design document for the existence of the blink_skia_config.gyp file, it was originally intended to be a gypi as proposed in this change. However, at the time, use of the '<(webkit_src_dir)' gyp variable was required to get the correct location of WebKit. Since variables do not expand in 'includes' in gyp, a gyp file was used instead so that it could be used in 'dependencies'. These limitations no longer exist and converting to a gypi allows for easier interoperation with gn. There will be a subsequent change to Chromium to use this new file, and then the existing gyp file will be removed in a follow-up change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M public/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M public/blink_skia_config.gyp View 1 chunk +0 lines, -1 line 0 comments Download
A public/blink_skia_config.gypi View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bungeman-chromium
The proposed Chromium side change is https://codereview.chromium.org/677513003/ .
6 years, 2 months ago (2014-10-23 21:43:46 UTC) #2
bungeman-chromium
6 years, 2 months ago (2014-10-23 21:58:38 UTC) #4
dglazkov
lgtm
6 years, 2 months ago (2014-10-23 22:07:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671323002/1
6 years, 2 months ago (2014-10-23 22:08:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:10:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184315

Powered by Google App Engine
This is Rietveld 408576698