Create an abstraction (MarkBit) object to hold the location of the...

src/heap.h

Index: src/heap.h
===================================================================
--- src/heap.h	(revision 7247)
+++ src/heap.h	(working copy)
@@ -1128,6 +1128,8 @@
   }
 
   static inline bool NextGCIsLikelyToBeFull() {
+    if (FLAG_gc_global) return true;
+
     intptr_t total_promoted =
         PromotedSpaceSize() + PromotedExternalMemorySize();
 
@@ -1771,7 +1773,7 @@
   // otherwise mark the object as overflowed and wait for a rescan of the
   // heap.
   void Push(HeapObject* object) {
-    CHECK(object->IsHeapObject());
+    ASSERT(object->IsHeapObject());
     if (is_full()) {
       object->SetOverflow();
       overflowed_ = true;
@@ -1783,7 +1785,7 @@
   HeapObject* Pop() {
     ASSERT(!is_empty());
     HeapObject* object = *(--top_);
-    CHECK(object->IsHeapObject());
+    ASSERT(object->IsHeapObject());

[Vyacheslav Egorov (Chromium), 2011/03/21 16:54:23]

Do we really want this?

Sometimes it's better to have an early detection of mark stack corruption.

[Erik Corry, 2011/03/21 20:48:53]

This is inlined in some of our hottest GC functions.  I'm going to follow the
pattern in the entire rest of the VM and leave sanity tests to the debug
version.

     return object;
   }