Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/store-buffer.h

Issue 6713069: Do not SortUniq store buffer before a regular iteration. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/store-buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 static StoreBufferMode store_buffer_mode() { return store_buffer_mode_; } 92 static StoreBufferMode store_buffer_mode() { return store_buffer_mode_; }
93 static inline void set_store_buffer_mode(StoreBufferMode mode); 93 static inline void set_store_buffer_mode(StoreBufferMode mode);
94 static bool old_buffer_is_sorted() { return old_buffer_is_sorted_; } 94 static bool old_buffer_is_sorted() { return old_buffer_is_sorted_; }
95 95
96 // Goes through the store buffer removing pointers to things that have 96 // Goes through the store buffer removing pointers to things that have
97 // been promoted. Rebuilds the store buffer completely if it overflowed. 97 // been promoted. Rebuilds the store buffer completely if it overflowed.
98 static void SortUniq(); 98 static void SortUniq();
99 static void Verify(); 99 static void Verify();
100 100
101 static void PrepareForIteration();
102
101 #ifdef DEBUG 103 #ifdef DEBUG
102 static void Clean(); 104 static void Clean();
103 // Slow, for asserts only. 105 // Slow, for asserts only.
104 static bool CellIsInStoreBuffer(Address cell); 106 static bool CellIsInStoreBuffer(Address cell);
105 #endif 107 #endif
106 108
107 private: 109 private:
108 // The store buffer is divided up into a new buffer that is constantly being 110 // The store buffer is divided up into a new buffer that is constantly being
109 // filled by mutator activity and an old buffer that is filled with the data 111 // filled by mutator activity and an old buffer that is filled with the data
110 // from the new buffer after compression. 112 // from the new buffer after compression.
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 StoreBuffer::may_move_store_buffer_entries_ = stored_state_; 165 StoreBuffer::may_move_store_buffer_entries_ = stored_state_;
164 } 166 }
165 167
166 private: 168 private:
167 bool stored_state_; 169 bool stored_state_;
168 }; 170 };
169 171
170 } } // namespace v8::internal 172 } } // namespace v8::internal
171 173
172 #endif // V8_WRITE_BARRIER_H_ 174 #endif // V8_WRITE_BARRIER_H_
OLDNEW
« no previous file with comments | « no previous file | src/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698