Provide lazy CommitPendingWrites in addition to eager SavePersistentPrefs.

chrome/common/important_file_writer.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
 #include "base/file_path.h"
@@ skipping 87 matching lines @@
   DCHECK(CalledOnValidThread());
   return timer_.IsRunning();
 }
 
 void ImportantFileWriter::WriteNow(const std::string& data) {
   DCHECK(CalledOnValidThread());
 
   if (HasPendingWrite())
     timer_.Stop();
 
-  if (!file_message_loop_proxy_->PostTask(FROM_HERE,
-                                          new WriteToDiskTask(path_, data))) {
+  if (!file_message_loop_proxy_->PostTask(
+      FROM_HERE, new WriteToDiskTask(path_, data))) {

[Mattias Nissler (ping if slow), 2011/03/25 15:29:57]

any reason for the formatting change here? I found the previous version easier
to read.

[Denis Lagno, 2011/03/25 15:41:22]

In old versions of CL there was argument added, now it is gone so it remained in
CL by mistake.

However at least one reason to prefer indentation on the right is that if you
ever need to rename some identifiers then indentation on the right will just
remain correct while indentation on the left needs to be reformatted.

     // Posting the task to background message loop is not expected
     // to fail, but if it does, avoid losing data and just hit the disk
     // on the current thread.
     NOTREACHED();
 
     WriteToDiskTask write_task(path_, data);
     write_task.Run();
   }
 }
 
@@ skipping 19 matching lines @@
   DCHECK(serializer_);
   std::string data;
   if (serializer_->SerializeData(&data)) {
     WriteNow(data);
   } else {
     LOG(WARNING) << "failed to serialize data to be saved in "
                  << path_.value();
   }
   serializer_ = NULL;
 }