Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.h

Issue 6713008: Don't destroy a request while it is being processed (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Rebased. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host.h
diff --git a/content/browser/renderer_host/resource_dispatcher_host.h b/content/browser/renderer_host/resource_dispatcher_host.h
index a177719ad56946c4c4f71dd0501667838fede0e2..33757df1c9b1cfce54343f4c6133b8c078d3b304 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.h
+++ b/content/browser/renderer_host/resource_dispatcher_host.h
@@ -317,8 +317,10 @@ class ResourceDispatcherHost : public net::URLRequest::Delegate {
// Helper function for regular and download requests.
void BeginRequestInternal(net::URLRequest* request);
- // Helper function that cancels |request|.
- void CancelRequestInternal(net::URLRequest* request, bool from_renderer);
+ // Helper function that cancels |request|. Returns whether the
+ // request was actually cancelled. If a renderer cancels a request
+ // for a download, we ignore the cancellation.
+ bool CancelRequestInternal(net::URLRequest* request, bool from_renderer);
// Helper function that inserts |request| into the resource queue.
void InsertIntoResourceQueue(

Powered by Google App Engine
This is Rietveld 408576698