Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 671273003: Parental controls only need to be Win7. (Closed)

Created:
6 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Parental controls only need to be Win7. Right now we are checking Vista in a Win8 file. Crazy. BUG=426573 Committed: https://crrev.com/13fa25624799207c073994ccce2df74f07a750af Cr-Commit-Position: refs/heads/master@{#300993}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/win/metro.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
cpu_(ooo_6.6-7.5)
ptal.
6 years, 2 months ago (2014-10-23 21:12:22 UTC) #2
scottmg
They seem to specify Vista in the docs http://msdn.microsoft.com/en-us/library/windows/desktop/ms711766(v=vs.85).aspx ?
6 years, 2 months ago (2014-10-23 21:22:32 UTC) #3
cpu_(ooo_6.6-7.5)
Yeah it supports that, but we don't want it.
6 years, 2 months ago (2014-10-23 21:34:49 UTC) #4
scottmg
If you say so. :) lgtm
6 years, 2 months ago (2014-10-23 21:37:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671273003/1
6 years, 2 months ago (2014-10-23 21:48:27 UTC) #7
grt (UTC plus 2)
drive-by https://codereview.chromium.org/671273003/diff/1/base/win/metro.cc File base/win/metro.cc (right): https://codereview.chromium.org/671273003/diff/1/base/win/metro.cc#newcode77 base/win/metro.cc:77: // Query this info on Windows 7 and ...
6 years, 2 months ago (2014-10-23 22:25:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 00:03:54 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:04:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13fa25624799207c073994ccce2df74f07a750af
Cr-Commit-Position: refs/heads/master@{#300993}

Powered by Google App Engine
This is Rietveld 408576698