Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 6712052: Allow the lid to be ignored using the use_lid pref (Closed)

Created:
9 years, 9 months ago by Benson Leung
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, davidjames, Sameer Nanda, Rhyland Klein
Visibility:
Public.

Description

Allow the lid to be ignored using the use_lid pref In the case where some devices have an optional lid, the presence of the SW_LID in one of the input events will cause powerm to treat that as a valid input and suspend or shutdown the system appropriately. Howevever, if the system doesn't physically have a lid but has one logically, we want the power manager to ignore inputs from that event based on a preference. This is done at powerm initialization, and is not dynamically changed. This change requires this changelist : http://codereview.chromium.org/6712051/ Change-Id: I16dba1389078a6dd367770db334f0aa8f4e20ec1 Signed-off-by: Benson Leung <bleung@chromium.org>; Signed-off-by: Todd Broch <tbroch@chromium.org>; BUG=chromium-os:13260 TEST= echo 0 > /var/lib/power_manager/use_lid sudo restart powerm Close the lid. Ensure that the lid is ignored. Watch /var/log/power_manager/powerm.LATEST for "Ignoring Lid." Boot a system without a lid. Ensure the system doesn't shut down or suspend. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=94e93d5

Patch Set 1 #

Patch Set 2 : Add default use_lid to config directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A config/use_lid View 1 1 chunk +1 line, -0 lines 0 comments Download
M power_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M power_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M powerman.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benson Leung
This CL will create a use_lid config for powerm that will support systems with a ...
9 years, 9 months ago (2011-03-19 07:05:59 UTC) #1
Benson Leung
Add tbroch to reviewers. ptal.
9 years, 9 months ago (2011-03-21 22:13:33 UTC) #2
tbroch1
9 years, 9 months ago (2011-03-22 20:06:48 UTC) #3
LGTM
On 2011/03/21 22:13:33, Benson Leung wrote:
> Add tbroch to reviewers. ptal.

Powered by Google App Engine
This is Rietveld 408576698