Issue 671193003: Subzero: Adjust expectations now that llvm-mc aligns calls not just naclcall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671193003: Subzero: Adjust expectations now that llvm-mc aligns calls not just naclcall. (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)

Modified:
6 years, 1 month ago

Reviewers:
kschimpf, Karl, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Adjust expectations now that llvm-mc aligns calls not just naclcall. Previously, llvm would emit naclcall instead of call to get the effect of bundle-align-to-end, but now it just emits plain calls and aligns plain calls like NaCl binutils would do. Adjust a few Subzero tests. See: https://codereview.chromium.org/647443005/ Currently leaving the nop checks loose in case the integrated assembler has some intermediate stage where it emits the bytes of a call in a "raw" manner (without padding). BUG=none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bd4ea5b4ba826cb9f94f54dff96449f2cb06e597

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	tests_lit/llvm2ice_tests/64bit.pnacl.ll	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/branch-opt.ll	View		3 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

jvoung (off chromium)

6 years, 1 month ago (2014-10-24 16:33:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd4ea5b4ba826cb9f94f54dff96449f2cb06e597 (presubmit successful).