Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 671183002: Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (Closed)

Created:
6 years, 2 months ago by Nikita (slow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/) Reason for revert: This breaks Chrome OS GAIA login. After successful GAIA authentication uses sees blank white page and nothing happens. Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow. Original issue's description: > Inline login handler extracts gaia id from HTTP header and seeds account tracker > service during sign in. > > BUG=341408 > > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a > Cr-Commit-Position: refs/heads/master@{#300750} TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org NOTREECHECKS=true NOTRY=true BUG=341408 Committed: https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce Cr-Commit-Position: refs/heads/master@{#300873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -438 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.h View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 2 chunks +26 lines, -42 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 4 chunks +30 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 6 chunks +42 lines, -26 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/gaia_auth/background.js View 5 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/resources/gaia_auth/main.js View 13 chunks +47 lines, -50 lines 0 comments Download
M chrome/browser/resources/gaia_auth/success.html View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/gaia_auth/success.js View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/gaia_auth_host.js View 7 chunks +46 lines, -49 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 6 chunks +8 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 5 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 12 chunks +31 lines, -37 lines 0 comments Download
M chromeos/login/auth/user_context.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chromeos/login/auth/user_context.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.h View 1 chunk +0 lines, -12 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M components/signin/core/browser/account_tracker_service_unittest.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M google_apis/gaia/fake_gaia.h View 3 chunks +0 lines, -13 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 6 chunks +4 lines, -41 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/main.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
Created Revert of Inline sign in extracts gaia id from HTTP header and seeds account ...
6 years, 2 months ago (2014-10-23 11:51:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671183002/1
6 years, 2 months ago (2014-10-23 11:52:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 11:53:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce Cr-Commit-Position: refs/heads/master@{#300873}
6 years, 2 months ago (2014-10-23 11:53:59 UTC) #4
bartfab (slow)
Bummer. I expect that the fix will be something trivial. Until then, reverting is the ...
6 years, 2 months ago (2014-10-23 11:56:00 UTC) #5
Nikita (slow)
On 2014/10/23 11:56:00, bartfab wrote: > Bummer. I expect that the fix will be something ...
6 years, 2 months ago (2014-10-23 11:57:52 UTC) #6
Nikita (slow)
6 years, 2 months ago (2014-10-24 14:34:28 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/677703002/ by nkostylev@chromium.org.

The reason for reverting is: White success page and no way to proceed only
reproduces for use_athena=1 builds.

This CL fixes that: https://codereview.chromium.org/642693003/

Re-landing..

Powered by Google App Engine
This is Rietveld 408576698