Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 671163003: Revert of Integrate SIMD optimisations for zlib (Closed)

Created:
6 years, 2 months ago by robert.bradford
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of https://codereview.chromium.org/552123005/) Reason for revert: Strong candidate for: multiple Linux MSan test failures with: SUMMARY: MemorySanitizer: use-of-uninitialized-value ??:0 ?? Including: CompressionUtilsTest.GzipCompression Original issue's description: > Integrate SIMD optimisations for zlib > > These optimisations have been published on zlib mailing list and at > https://github.com/jtkukunas/zlib/ > > This change merges the following optimisation patches: > - "For x86, add CPUID check." > - "Adds SSE2 optimized hash shifting to fill_window." > - "add SSE4.2 optimized hash function" > - "add PCLMULQDQ optimized CRC folding" > > From Jim Kukunas <james.t.kukunas@linux.intel.com>; and adapts them to the > current zlib version in Chromium. > > The optimisations are enabled at runtime if all the necessary CPU features are > present. As the optimisations require extra cflags to enable the compiler to > use the instructions the optimisations are held in their own static library > with a stub implementation to allow linking on other platforms. > > TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance > improvement seen on RoboHornet benchmark on Linux Desktop > BUG=401517 > > Committed: https://crrev.com/e045ec106de29562ae94eafccde49a7b73848471 > Cr-Commit-Position: refs/heads/master@{#300866} TBR=agl@chromium.org,nathan.d.ciobanu@intel.com NOTREECHECKS=true NOTRY=true BUG=401517 Committed: https://crrev.com/ca54b3014721cdc27e4a17dd2c82fe5811fa39cc Cr-Commit-Position: refs/heads/master@{#300889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1166 lines) Patch
M net/spdy/spdy_framer_test.cc View 4 chunks +7 lines, -166 lines 0 comments Download
M third_party/zlib/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
M third_party/zlib/README.chromium View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/zlib/crc32.c View 2 chunks +0 lines, -27 lines 0 comments Download
D third_party/zlib/crc_folding.c View 1 chunk +0 lines, -478 lines 0 comments Download
M third_party/zlib/deflate.h View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/zlib/deflate.c View 18 chunks +28 lines, -76 lines 0 comments Download
D third_party/zlib/fill_window_sse.c View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/zlib/simd_stub.c View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/zlib/x86.h View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/zlib/x86.c View 1 chunk +0 lines, -90 lines 0 comments Download
M third_party/zlib/zlib.gyp View 3 chunks +0 lines, -23 lines 0 comments Download
M third_party/zlib/zutil.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
robert.bradford
Created Revert of Integrate SIMD optimisations for zlib
6 years, 2 months ago (2014-10-23 14:43:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671163003/1
6 years, 2 months ago (2014-10-23 14:44:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-23 14:44:32 UTC) #4
Avi (use Gerrit)
On 2014/10/23 14:44:32, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 2 months ago (2014-10-23 14:45:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671163003/1
6 years, 2 months ago (2014-10-23 15:04:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 15:05:43 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 15:06:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca54b3014721cdc27e4a17dd2c82fe5811fa39cc
Cr-Commit-Position: refs/heads/master@{#300889}

Powered by Google App Engine
This is Rietveld 408576698