extensions/common/permissions/extensions_api_permissions.cc - Issue 671163002: Add new extension API for VPN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 671163002: Add new extension API for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added an optional callback to methods in the idl Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/extensions_api_permissions.cc

diff --git a/extensions/common/permissions/extensions_api_permissions.cc b/extensions/common/permissions/extensions_api_permissions.cc

index 936a8e22b7965bbb489cfebb0ae4e5a90e5e861e..7e8a1ee96e918b67dea308552eda0bd411a624d7 100644

--- a/extensions/common/permissions/extensions_api_permissions.cc

+++ b/extensions/common/permissions/extensions_api_permissions.cc

@@ -80,6 +80,9 @@ std::vector<APIPermissionInfo*> ExtensionsAPIPermissions::GetAllPermissions()

{APIPermission::kVideoCapture, "videoCapture",

APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_VIDEO_CAPTURE,

PermissionMessage::kVideoCapture},

+ {APIPermission::kVpnProvider, "vpnProvider",

+ APIPermissionInfo::kFlagCannotBeOptional,

+ IDS_EXTENSION_PROMPT_WARNING_VPN, PermissionMessage::kVpnProvider},

// NOTE(kalman): This is provided by a manifest property but needs to

// appear in the install permission dialogue, so we need a fake

// permission for it. See http://crbug.com/247857.