Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 671113002: Disable old hotword extension when new hotwording is enabled. (Closed)

Created:
6 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 2 months ago
Reviewers:
rpetterson
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable old hotword extension when new hotwording is enabled. BUG=397019 Committed: https://crrev.com/26c09aac0e5c2018f232bb9d77105731034d0bc2 Cr-Commit-Position: refs/heads/master@{#300977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/browser/search/hotword_service.cc View 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Anand Mistry (off Chromium)
6 years, 2 months ago (2014-10-23 05:29:21 UTC) #2
rpetterson
LGTM I assume the new extension is enabled by default? What about the shared module? ...
6 years, 2 months ago (2014-10-23 18:41:17 UTC) #3
Anand Mistry (off Chromium)
On 2014/10/23 18:41:17, rpetterson wrote: > LGTM > > I assume the new extension is ...
6 years, 2 months ago (2014-10-23 21:29:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671113002/1
6 years, 2 months ago (2014-10-23 21:31:40 UTC) #6
rpetterson
On 2014/10/23 21:29:44, Anand Mistry wrote: > On 2014/10/23 18:41:17, rpetterson wrote: > > LGTM ...
6 years, 2 months ago (2014-10-23 21:32:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 23:26:39 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:27:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26c09aac0e5c2018f232bb9d77105731034d0bc2
Cr-Commit-Position: refs/heads/master@{#300977}

Powered by Google App Engine
This is Rietveld 408576698