Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6711027: [Isolates] Merge 7201:7258 from bleeding_edge to isolates. (Closed)

Created:
9 years, 9 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

[Isolates] Merge 7201:7258 from bleeding_edge to isolates. Committed: http://code.google.com/p/v8/source/detail?r=7255

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1681 lines, -562 lines) Patch
M ChangeLog View 1 chunk +15 lines, -0 lines 0 comments Download
M MERGE View 1 chunk +1 line, -1 line 0 comments Download
M include/v8.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +20 lines, -11 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 6 chunks +66 lines, -42 lines 0 comments Download
M src/assembler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 12 chunks +303 lines, -91 lines 0 comments Download
M src/builtins.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +33 lines, -1 line 0 comments Download
M src/code-stubs.h View 3 chunks +21 lines, -2 lines 0 comments Download
M src/codegen.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/codegen-inl.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/contexts.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/factory.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/factory.cc View 4 chunks +21 lines, -10 lines 0 comments Download
M src/global-handles.h View 3 chunks +33 lines, -7 lines 0 comments Download
M src/global-handles.cc View 2 chunks +34 lines, -4 lines 1 comment Download
M src/handles.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +8 lines, -3 lines 0 comments Download
M src/heap.cc View 2 chunks +25 lines, -10 lines 0 comments Download
M src/hydrogen.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +34 lines, -33 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +20 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +22 lines, -11 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 14 chunks +59 lines, -55 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +56 lines, -9 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +72 lines, -46 lines 0 comments Download
M src/mark-compact.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/mark-compact.cc View 5 chunks +37 lines, -9 lines 0 comments Download
M src/messages.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/platform-posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/serialize.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/stub-cache.h View 3 chunks +12 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +34 lines, -15 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +21 lines, -11 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/x64/disasm-x64.cc View 7 chunks +31 lines, -16 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +54 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +17 lines, -9 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 6 chunks +70 lines, -49 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +188 lines, -6 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 4 chunks +44 lines, -6 lines 0 comments Download
M test/es5conform/es5conform.status View 1 chunk +2 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-1257.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Titov
TBR=vitalyr
9 years, 9 months ago (2011-03-18 02:50:40 UTC) #1
Vitaly Repeshko
9 years, 9 months ago (2011-03-18 10:38:00 UTC) #2 
LGTM

http://codereview.chromium.org/6711027/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

http://codereview.chromium.org/6711027/diff/1/src/global-handles.cc#newcode571
src/global-handles.cc:571: static List<ImplicitRefGroup*> groups(4);
This must be made non-static. I'll fix.

Powered by Google App Engine
This is Rietveld 408576698