Issue 671043002: Offline interstitial mobile fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 671043002: Offline interstitial mobile fixes (Closed)

Created:
6 years, 2 months ago by newt (away)

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Offline interstitial mobile fixes + Switch textContent to innerHTML to accommodate strings with HTML + Hide the details button with inline style to override the media query. BUG=420888 Committed: https://crrev.com/836d61020dcfcf3becfd42172fb73a423551ea17 Cr-Commit-Position: refs/heads/master@{#298539} Committed: https://chromium.googlesource.com/chromium/src/+/dda1f1304be0d5f3aea327248504a6cff80cf61a

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/renderer/resources/neterror.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

newt (away)

6 years, 2 months ago (2014-10-22 20:01:49 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dda1f1304be0d5f3aea327248504a6cff80cf61a.