Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 671033002: Expose HTML pre tag with correct MSAA+IA2 Role (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Expose HTML pre tag with correct MSAA+IA2 Role According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html HTML pre tag should be exposed as follow: MSAA + IAccessible2 Role: IA2_ROLE_PARAGRAPH AX AXRole: AXGroup AXSubrole: (nil) AXRoleDescription: "group" This CL depends on blink side CL https://codereview.chromium.org/671003002/ (Reverted) Re-Land CL https://codereview.chromium.org/663233004/ BUG=426053 TBR=kalman Committed: https://crrev.com/c7c5264348c68c3326a21c952dc17ddeadeca63a Cr-Commit-Position: refs/heads/master@{#301321}

Patch Set 1 #

Patch Set 2 : Uploading expectations for mac and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/pre.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/pre-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/pre-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/pre-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-10-24 08:10:14 UTC) #2
dmazzoni
lgtm Note - this can't land until after the next Blink roll.
6 years, 2 months ago (2014-10-24 08:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671033002/20001
6 years, 1 month ago (2014-10-25 13:16:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20078)
6 years, 1 month ago (2014-10-25 13:21:49 UTC) #7
shreeramk
kalman@chromium.org: Please review changes in automation.idl Thanks!
6 years, 1 month ago (2014-10-25 14:06:15 UTC) #9
dmazzoni
TBR: kalman
6 years, 1 month ago (2014-10-27 06:01:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/671033002/20001
6 years, 1 month ago (2014-10-27 06:01:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 06:59:05 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 06:59:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7c5264348c68c3326a21c952dc17ddeadeca63a
Cr-Commit-Position: refs/heads/master@{#301321}

Powered by Google App Engine
This is Rietveld 408576698