Issue 6710001: Enforce SavePersistentPrefs in RestartJob path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6710001: Enforce SavePersistentPrefs in RestartJob path. (Closed)

Created:
9 years, 9 months ago by Denis Lagno

Modified:
9 years, 6 months ago

Reviewers:
Nikita (slow), DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enforce SavePersistentPrefs in RestartJob path. Settings saved via ScheduleSavePersistentPrefs may be lost if exitted via chromeos::RestartJob. Evidence of those losses were observed on debug build: change language on new user pod and then start new incognito session: in ~20-30% cases changed language is lost. BUG=chromium-os:13102 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78683

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/cros/login_library.cc	View		2 chunks	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

9 years, 9 months ago (2011-03-17 16:04:40 UTC) #2

LGTM

http://codereview.chromium.org/6710001/diff/1/chrome/browser/chromeos/cros/lo...
File chrome/browser/chromeos/cros/login_library.cc (right):

http://codereview.chromium.org/6710001/diff/1/chrome/browser/chromeos/cros/lo...
chrome/browser/chromeos/cros/login_library.cc:135: // XXX: normally this call
must not be needed, however it turned out that
Please comment in this one too
http://code.google.com/p/chromium-os/issues/detail?id=6924

Expand Messages | Collapse Messages