Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 6710001: Enforce SavePersistentPrefs in RestartJob path. (Closed)

Created:
8 years, 2 months ago by Denis Lagno
Modified:
7 years, 11 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enforce SavePersistentPrefs in RestartJob path. Settings saved via ScheduleSavePersistentPrefs may be lost if exitted via chromeos::RestartJob. Evidence of those losses were observed on debug build: change language on new user pod and then start new incognito session: in ~20-30% cases changed language is lost. BUG=chromium-os:13102 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78683

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/chromeos/cros/login_library.cc View 2 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Denis Lagno
please take a look
8 years, 2 months ago (2011-03-17 15:33:04 UTC) #1
Nikita (slow)
8 years, 2 months ago (2011-03-17 16:04:40 UTC) #2
LGTM

http://codereview.chromium.org/6710001/diff/1/chrome/browser/chromeos/cros/lo...
File chrome/browser/chromeos/cros/login_library.cc (right):

http://codereview.chromium.org/6710001/diff/1/chrome/browser/chromeos/cros/lo...
chrome/browser/chromeos/cros/login_library.cc:135: // XXX: normally this call
must not be needed, however it turned out that
Please comment in this one too
http://code.google.com/p/chromium-os/issues/detail?id=6924

Powered by Google App Engine
This is Rietveld 408576698