Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 670993003: Instrumenting callbacks of HttpNetworkTransaction to locate the source of jankiness (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
asanka, pfeldman
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, Vladislav Kaznacheev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting most popular callbacks of HttpNetworkTransaction to locate the source of jankiness. Previous instrumentations showed that "DoCallback(rv);" call inside HttpNetworkTransaction::OnIOComplete alone is responsible for 18.2 janks per hour in IO thread. I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=424359 Committed: https://crrev.com/29494d86acbce67d901844d75e4ba76ceb84cf4b Cr-Commit-Position: refs/heads/master@{#302650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_network_transaction.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
vadimt
asanka@chromium.org: Please provide OWNER's approval for net/ kaznacheev@chromium.org: Please provide OWNER's approval for devtools
6 years, 1 month ago (2014-10-30 21:07:07 UTC) #2
Vladislav Kaznacheev
On 2014/10/30 21:07:07, vadimt wrote: > mailto:asanka@chromium.org: Please provide OWNER's approval for net/ > > ...
6 years, 1 month ago (2014-10-31 00:40:23 UTC) #3
vadimt
pfeldman@, please provide OWNERs approval for devtools/ code. kaznacheev@, you might want to consider removing ...
6 years, 1 month ago (2014-10-31 01:24:21 UTC) #6
pfeldman
lgtm
6 years, 1 month ago (2014-10-31 06:17:33 UTC) #7
asanka
lgtm
6 years, 1 month ago (2014-11-04 03:06:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670993003/1
6 years, 1 month ago (2014-11-04 15:17:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/25059)
6 years, 1 month ago (2014-11-04 17:04:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670993003/1
6 years, 1 month ago (2014-11-04 19:14:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 20:06:33 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:07:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29494d86acbce67d901844d75e4ba76ceb84cf4b
Cr-Commit-Position: refs/heads/master@{#302650}

Powered by Google App Engine
This is Rietveld 408576698