Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: pkg/intl/bin/generate_from_arb.dart

Issue 670933004: Fix a couple of Dart style naming violations in Intl (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Review fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/intl/CHANGELOG.md ('k') | pkg/intl/lib/date_symbol_data_http_request.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env dart 1 #!/usr/bin/env dart
2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
3 // for details. All rights reserved. Use of this source code is governed by a 3 // for details. All rights reserved. Use of this source code is governed by a
4 // BSD-style license that can be found in the LICENSE file. 4 // BSD-style license that can be found in the LICENSE file.
5 5
6 /** 6 /**
7 * A main program that takes as input a source Dart file and a number 7 * A main program that takes as input a source Dart file and a number
8 * of ARB files representing translations of messages from the corresponding 8 * of ARB files representing translations of messages from the corresponding
9 * Dart file. See extract_to_arb.dart and make_hardcoded_translation.dart. 9 * Dart file. See extract_to_arb.dart and make_hardcoded_translation.dart.
10 * 10 *
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 super(name, translated); 130 super(name, translated);
131 131
132 List<MainMessage> get originalMessages => (super.originalMessages == null) ? 132 List<MainMessage> get originalMessages => (super.originalMessages == null) ?
133 _findOriginals() : super.originalMessages; 133 _findOriginals() : super.originalMessages;
134 134
135 // We know that our [id] is the name of the message, which is used as the 135 // We know that our [id] is the name of the message, which is used as the
136 //key in [messages]. 136 //key in [messages].
137 List<MainMessage> _findOriginals() => originalMessages = messages[id]; 137 List<MainMessage> _findOriginals() => originalMessages = messages[id];
138 } 138 }
139 139
140 final pluralAndGenderParser = new ICUParser().message; 140 final pluralAndGenderParser = new IcuParser().message;
141 final plainParser = new ICUParser().nonIcuMessage; 141 final plainParser = new IcuParser().nonIcuMessage;
OLDNEW
« no previous file with comments | « pkg/intl/CHANGELOG.md ('k') | pkg/intl/lib/date_symbol_data_http_request.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698