Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: src/global-handles.cc

Issue 6709026: [Isolates] Small fixes after the last merge. (Closed)
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/global-handles.h ('k') | src/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/global-handles.cc
diff --git a/src/global-handles.cc b/src/global-handles.cc
index b4dd027c18af9b26237f78f73dbe30030a8a9c41..4d138597b1282a7b46a7f9ed5444271219ff1ce9 100644
--- a/src/global-handles.cc
+++ b/src/global-handles.cc
@@ -566,13 +566,6 @@ void GlobalHandles::AddObjectGroup(Object*** handles,
}
-List<ImplicitRefGroup*>* GlobalHandles::ImplicitRefGroups() {
- // Lazily initialize the list to avoid startup time static constructors.
- static List<ImplicitRefGroup*> groups(4);
- return &groups;
-}
-
-
void GlobalHandles::AddImplicitReferences(HeapObject* parent,
Object*** children,
size_t length) {
@@ -580,12 +573,12 @@ void GlobalHandles::AddImplicitReferences(HeapObject* parent,
for (size_t i = 0; i < length; ++i) {
new_entry->children_.Add(children[i]);
}
- ImplicitRefGroups()->Add(new_entry);
+ implicit_ref_groups_.Add(new_entry);
}
void GlobalHandles::RemoveObjectGroups() {
- for (int i = 0; i< object_groups_.length(); i++) {
+ for (int i = 0; i < object_groups_.length(); i++) {
delete object_groups_.at(i);
}
object_groups_.Clear();
@@ -593,11 +586,10 @@ void GlobalHandles::RemoveObjectGroups() {
void GlobalHandles::RemoveImplicitRefGroups() {
- List<ImplicitRefGroup*>* ref_groups = ImplicitRefGroups();
- for (int i = 0; i< ref_groups->length(); i++) {
- delete ref_groups->at(i);
+ for (int i = 0; i < implicit_ref_groups_.length(); i++) {
+ delete implicit_ref_groups_.at(i);
}
- ref_groups->Clear();
+ implicit_ref_groups_.Clear();
}
« no previous file with comments | « src/global-handles.h ('k') | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698