Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: src/assembler.h

Issue 6709022: Re-establish mips basic infrastructure. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/SConscript ('k') | src/assembler.cc » ('j') | src/mips/assembler-mips.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index b66421a2e72a1cb97137d45d66bbba441ac41fb0..442ffaadb7fe12954b32a4e7af4df64c11f2a6dc 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -358,6 +358,17 @@ class RelocInfo BASE_EMBEDDED {
byte* pc_;
Mode rmode_;
intptr_t data_;
+ // Code and Embedded Object pointers in mips are stored split across
Søren Thygesen Gjesse 2011/03/21 16:05:19 I don't like these platform dependent members here
Paul Lind 2011/03/23 01:55:43 I have removed this for now, since relocation is n
+ // two consecutive 32-bit instructions. Heap management routines expect
+ // to access these pointers indirectly. The following location provides
+ // a place for these pointers to exist natually when accessed via the
+ // Iterator. Its address is returned by RelocInfo::target_object_address().
+ Object *reconstructed_obj_ptr_;
+ // External-reference pointers may also be split across instruction-pairs
+ // in mips, but are accessed via indirect pointers. This location provides
+ // a place for that pointer to exist naturally. Its address is returned by
+ // RelocInfo::target_reference_address().
+ Address reconstructed_adr_ptr_;
friend class RelocIterator;
};
« no previous file with comments | « src/SConscript ('k') | src/assembler.cc » ('j') | src/mips/assembler-mips.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698