Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 670893003: Add window.postMessage() use counters. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add window.postMessage() use counters. Instrument postMessage() to determine usage of the overload postMessage(data, origin, transferables) R=mkwst BUG=425896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184160

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 3 chunks +5 lines, -0 lines 2 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-22 07:53:22 UTC) #2
Mike West
LGTM. Might point to the blink-dev thread in the CL description, since I assume that's ...
6 years, 2 months ago (2014-10-22 07:57:01 UTC) #3
sof
https://codereview.chromium.org/670893003/diff/1/Source/bindings/core/v8/custom/V8WindowCustom.cpp File Source/bindings/core/v8/custom/V8WindowCustom.cpp (right): https://codereview.chromium.org/670893003/diff/1/Source/bindings/core/v8/custom/V8WindowCustom.cpp#newcode250 Source/bindings/core/v8/custom/V8WindowCustom.cpp:250: UseCounter::countIfNotPrivateScript(info.GetIsolate(), window->document(), UseCounter::WindowPostMessage); On 2014/10/22 07:57:01, Mike West wrote: ...
6 years, 2 months ago (2014-10-22 08:00:33 UTC) #4
sof
On 2014/10/22 07:57:01, Mike West wrote: > LGTM. Might point to the blink-dev thread in ...
6 years, 2 months ago (2014-10-22 08:11:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670893003/1
6 years, 2 months ago (2014-10-22 08:12:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 10:16:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184160

Powered by Google App Engine
This is Rietveld 408576698