LayoutTests/fast/scrolling/scrolling-apis-nan-scroll-position.html - Issue 670833002: Early out if the scroll position passed in by js is NaN

Side by Side Diff: LayoutTests/fast/scrolling/scrolling-apis-nan-scroll-position.html

Issue 670833002: Early out if the scroll position passed in by js is NaN (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <style>

	3 .spacer {

	4 height: 1000px;

	5 width: 1000px;

	6 }

	7

	8 #scroller {

	9 height: 100px;

	10 width: 100px;

	11 overflow: scroll;

	12 }

	13 </style>

	14

	15 <body style="width:30000px;height:30000px" onload="runTest()">

	16 <div id=scroller>

	17 <div class=spacer></div>

	18 </div>

	19 </body>

	20

	21 <script src="../../resources/js-test.js"></script>

	22 <script>

	23 description("Verifies that nan scroll position works correctly.");

	24

	25 function scroll()

	26 {
	Rick Byers 2014/10/21 22:22:33 you should start by scrolling to some specific pos you should start by scrolling to some specific position (eg. 1,1) so the test can detect the difference betweeen converting NaN to 0 and actually scrolling back to 0. Yufeng Shen (Slow to review) 2014/10/21 22:49:31 Done. Show quoted text On 2014/10/21 22:22:33, Rick Byers wrote: > you should start by scrolling to some specific position (eg. 1,1) so the test > can detect the difference betweeen converting NaN to 0 and actually scrolling > back to 0. Done.
	27 // window.nan is undefined so NaN.
	Rick Byers 2014/10/21 22:22:33 technically NaN and undefined are different in JS. technically NaN and undefined are different in JS. If you want to actually use NaN then use window.NaN (note case). If you want undefined then use just 'undefined'. Testing either (or some combination of both) is probably fine since the bindings (I assume) convert both to NaN. Yufeng Shen (Slow to review) 2014/10/21 22:49:31 window.NaN is used. Show quoted text On 2014/10/21 22:22:33, Rick Byers wrote: > technically NaN and undefined are different in JS. If you want to actually use > NaN then use window.NaN (note case). If you want undefined then use just > 'undefined'. Testing either (or some combination of both) is probably fine > since the bindings (I assume) convert both to NaN. window.NaN is used.
	28 window.scrollTo(window.nan, window.nan);

	29 shouldBe("document.documentElement.scrollTop", "0");

	30 shouldBe("document.documentElement.scrollLeft", "0");

	31

	32 window.scrollBy(window.nan, window.nan);

	33 shouldBe("document.documentElement.scrollTop", "0");

	34 shouldBe("document.documentElement.scrollLeft", "0");

	35

	36 document.body.scrollTop = window.nan;
	Rick Byers 2014/10/21 22:22:33 Once you scroll the document these will probably s Once you scroll the document these will probably start failing (body isn't technically scrollable in the standard behavior which we have enabled by default for tests). May want to just exclude the body case. Yufeng Shen (Slow to review) 2014/10/21 22:49:31 Done. Show quoted text On 2014/10/21 22:22:33, Rick Byers wrote: > Once you scroll the document these will probably start failing (body isn't > technically scrollable in the standard behavior which we have enabled by default > for tests). May want to just exclude the body case. Done.
	37 shouldBe("document.body.scrollTop", "0");

	38 document.body.scrollLeft = window.nan

	39 shouldBe("document.body.scrollLeft", "0");

	40

	41 scroller.scrollTop = window.nan;

	42 shouldBe("scroller.scrollTop", "0");

	43 scroller.scrollLeft = window.nan;

	44 shouldBe("scroller.scrollLeft", "0");

	45 }

	46

	47 function runTest()

	48 {

	49 if (window.eventSender)

	50 scroll();

	51 }

	52

	53 </script>

	54 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/scrolling/scrolling-apis-nan-scroll-position-expected.txt » ('j') | Source/core/frame/LocalDOMWindow.cpp » ('J')