Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 67083003: Move WebMediaPlayer and friends to public/platform/ (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink, philipj_slow, feature-media-reviews_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move WebMediaPlayer and friends to public/platform/ This is a prerequisite for eliminating the MediaPlayer/MediaPlayerClient layer. Minor style changes were needed to pass presubmit. BUG=310466 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -212 lines) Patch
A + public/platform/WebAudioSourceProviderClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/WebMediaPlayer.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + public/platform/WebMediaPlayerClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/web/WebAudioSourceProviderClient.h View 1 chunk +1 line, -15 lines 0 comments Download
M public/web/WebMediaPlayer.h View 1 chunk +1 line, -134 lines 0 comments Download
M public/web/WebMediaPlayerClient.h View 1 chunk +1 line, -59 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-10 12:52:11 UTC) #1
philipj_slow
7 years, 1 month ago (2013-11-11 09:51:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-11 10:03:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/67083003/1
7 years, 1 month ago (2013-11-11 10:34:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/67083003/1
7 years, 1 month ago (2013-11-12 09:51:10 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 10:52:47 UTC) #6
Message was sent while issue was closed.
Change committed as 161792

Powered by Google App Engine
This is Rietveld 408576698