Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 670813003: Add a header string for Multiple Automatic Downloads. (Closed)

Created:
6 years, 2 months ago by Daniel Nishi
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a header string for Multiple Automatic Downloads on the Content Settings page. BUG=418882 Committed: https://crrev.com/df6be1e2efe2708778b170f0c88dd1763d22b710 Cr-Commit-Position: refs/heads/master@{#300698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Nishi
PTAL when you get a chance.
6 years, 2 months ago (2014-10-21 20:05:59 UTC) #2
Bernhard Bauer
LGTM, but a better description would be to explain what you're doing, not the bug ...
6 years, 2 months ago (2014-10-22 08:40:54 UTC) #3
Daniel Nishi
On 2014/10/22 08:40:54, Bernhard Bauer wrote: > LGTM, but a better description would be to ...
6 years, 2 months ago (2014-10-22 15:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670813003/1
6 years, 2 months ago (2014-10-22 15:41:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 17:42:22 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:43:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df6be1e2efe2708778b170f0c88dd1763d22b710
Cr-Commit-Position: refs/heads/master@{#300698}

Powered by Google App Engine
This is Rietveld 408576698