Issue 6708029: Lands http://codereview.chromium.org/2928005/ for Dill:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6708029: Lands http://codereview.chromium.org/2928005/ for Dill: (Closed)

Created:
9 years, 9 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Lands http://codereview.chromium.org/2928005/ for Dill: Loads favicons when openning back/forward menu for any urls that don't have favicons. BUG=5679 TEST=Restore a tab with a navigation history, check favicons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79000

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -18 lines)			Patch
M	app/app_base.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/clock_menu_button.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/input_method_menu.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/power_menu_button.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model.h	View		4 chunks	+33 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model.cc	View		6 chunks	+74 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc	View		2 chunks	+99 lines, -0 lines	0 comments	Download
M	ui/base/models/menu_model.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
A	ui/base/models/menu_model_delegate.h	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	ui/base/models/simple_menu_model.h	View		4 chunks	+6 lines, -1 line	0 comments	Download
M	ui/base/models/simple_menu_model.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	views/view_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download