Issue 670773004: Update socket_libevent.cc to build on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 670773004: Update socket_libevent.cc to build on android (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
Chris Masone

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update socket_libevent.cc to build on android Android ships with crazy old system headers that don't include the SOCK_NONBLOCK define. Since this is easy to live without, update the domain socket code to set the socket to nonblocking using an fcntl when built without this define. Still use SOCK_NONBLOCK when available since it's cheaper to avoid the fcntl. R=cmasone@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d15579edf090dfdcad350bcc4f50e94e1dd7e276

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	mojo/shell/domain_socket/socket_libevent.cc	View		3 chunks	+18 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

6 years, 1 month ago (2014-10-27 18:04:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d15579edf090dfdcad350bcc4f50e94e1dd7e276 (presubmit successful).

Expand Messages | Collapse Messages