Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 670773002: cc: Add a unittest for an early out patch. (Closed)

Created:
6 years, 2 months ago by vmpstr
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add a unittest for an early out patch. This patch adds a unittest for https://codereview.chromium.org/667053003/ The test fails without the patch and passes with. R=enne, skyostil Committed: https://crrev.com/19ae0a5c1108fa90a494ce111b8ae68ccce2e161 Cr-Commit-Position: refs/heads/master@{#300683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmpstr
PTAL. This is a test for https://codereview.chromium.org/667053003/
6 years, 2 months ago (2014-10-21 18:05:36 UTC) #1
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-21 18:35:30 UTC) #2
Sami
lgtm, thank you! To be clear, I think not delaying the fix over this test ...
6 years, 2 months ago (2014-10-22 10:23:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670773002/1
6 years, 2 months ago (2014-10-22 14:39:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 15:32:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:33:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19ae0a5c1108fa90a494ce111b8ae68ccce2e161
Cr-Commit-Position: refs/heads/master@{#300683}

Powered by Google App Engine
This is Rietveld 408576698