Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 670763003: Add tools/checkperms/ from the chromium repo (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Add tools/checkperms/ from the chromium repo This is referenced by the presubmit. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dffc411c2a2d1c3bf02be3c402b8b9327cca06cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -4 lines) Patch
A tools/checkperms/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/checkperms/PRESUBMIT.py View 2 chunks +6 lines, -4 lines 0 comments Download
A tools/checkperms/checkperms.py View 1 chunk +480 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years, 2 months ago (2014-10-21 20:31:34 UTC) #2
viettrungluu
lgtm
6 years, 2 months ago (2014-10-21 21:06:42 UTC) #3
jamesr
6 years, 2 months ago (2014-10-21 21:16:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dffc411c2a2d1c3bf02be3c402b8b9327cca06cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698