Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 670743002: Mojo: Fixes to current virtual/override style in mojo/edk/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Fixes to current virtual/override style in mojo/edk/. This was mostly done in https://codereview.chromium.org/668663006/, but: * it missed things deriving from testing::Test for some reason; * it didn't touch Windows-only files (for more obvious reasons). R=sky@chromium.org BUG=417463 Committed: https://chromium.googlesource.com/chromium/src/+/3a09fd48b0780995311f1cebc1b87c3648dc0552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/core_test_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/raw_channel_win.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 15:10:44 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-10-21 16:00:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/670743002/1
6 years, 2 months ago (2014-10-21 16:03:58 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a09fd48b0780995311f1cebc1b87c3648dc0552 Cr-Commit-Position: refs/heads/master@{#300502}
6 years, 2 months ago (2014-10-21 16:54:46 UTC) #5
viettrungluu
6 years, 2 months ago (2014-10-21 16:54:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a09fd48b0780995311f1cebc1b87c3648dc0552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698