Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 67070: Merge 13131 - Make the throbber throb sooner after you navigate. This fixes t... (Closed)

Created:
11 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 13131 - Make the throbber throb sooner after you navigate. This fixes the new tab page, which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Review URL: http://codereview.chromium.org/60066 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13567

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -34 lines) Patch
M chrome/browser/browser.cc View 1 4 chunks +20 lines, -9 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_renderer.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 8 months ago (2009-04-11 21:01:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698