Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 67069: Merge 13072 - A workaround fix for Issue 9186.... (Closed)

Created:
11 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 13072 - A workaround fix for Issue 9186. This crash is caused in a unnecessary check whether or not to add a "text direction" submenu to a context menu. Since we don't have a "text direction" submenu and this check is unnecessary now, this change set a page setting that disables this check. BUG=9186 Review URL: http://codereview.chromium.org/42690 TBR=hbono@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webkit/glue/webview_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 8 months ago (2009-04-11 20:01:11 UTC) #1
Hironori Bono
11 years, 8 months ago (2009-04-13 04:54:50 UTC) #2
LGTM.
Thank you for merging this fix.

Powered by Google App Engine
This is Rietveld 408576698