Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: content/renderer/v8_value_converter_impl_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/v8_value_converter_impl.h ('k') | content/renderer/web_ui_extension_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/v8_value_converter_impl_unittest.cc
diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc
index b4bcb5f68a89a4dde78d21e8b931c0240250a5fb..2b44b1296f2a1bd0d75e973005f2a6344d39501c 100644
--- a/content/renderer/v8_value_converter_impl_unittest.cc
+++ b/content/renderer/v8_value_converter_impl_unittest.cc
@@ -716,33 +716,32 @@ class V8ValueConverterOverridingStrategyForTesting
public:
V8ValueConverterOverridingStrategyForTesting()
: reference_value_(NewReferenceValue()) {}
- virtual bool FromV8Object(
- v8::Handle<v8::Object> value,
- base::Value** out,
- v8::Isolate* isolate,
- const FromV8ValueCallback& callback) const override {
+ bool FromV8Object(v8::Handle<v8::Object> value,
+ base::Value** out,
+ v8::Isolate* isolate,
+ const FromV8ValueCallback& callback) const override {
*out = NewReferenceValue();
return true;
}
- virtual bool FromV8Array(v8::Handle<v8::Array> value,
- base::Value** out,
- v8::Isolate* isolate,
- const FromV8ValueCallback& callback) const override {
+ bool FromV8Array(v8::Handle<v8::Array> value,
+ base::Value** out,
+ v8::Isolate* isolate,
+ const FromV8ValueCallback& callback) const override {
*out = NewReferenceValue();
return true;
}
- virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
- base::Value** out,
- v8::Isolate* isolate) const override {
+ bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
+ base::Value** out,
+ v8::Isolate* isolate) const override {
*out = NewReferenceValue();
return true;
}
- virtual bool FromV8Number(v8::Handle<v8::Number> value,
- base::Value** out) const override {
+ bool FromV8Number(v8::Handle<v8::Number> value,
+ base::Value** out) const override {
*out = NewReferenceValue();
return true;
}
- virtual bool FromV8Undefined(base::Value** out) const override {
+ bool FromV8Undefined(base::Value** out) const override {
*out = NewReferenceValue();
return true;
}
@@ -809,31 +808,28 @@ TEST_F(V8ValueConverterImplTest, StrategyOverrides) {
class V8ValueConverterBypassStrategyForTesting
: public V8ValueConverter::Strategy {
public:
- virtual bool FromV8Object(
- v8::Handle<v8::Object> value,
- base::Value** out,
- v8::Isolate* isolate,
- const FromV8ValueCallback& callback) const override {
+ bool FromV8Object(v8::Handle<v8::Object> value,
+ base::Value** out,
+ v8::Isolate* isolate,
+ const FromV8ValueCallback& callback) const override {
return false;
}
- virtual bool FromV8Array(v8::Handle<v8::Array> value,
- base::Value** out,
- v8::Isolate* isolate,
- const FromV8ValueCallback& callback) const override {
+ bool FromV8Array(v8::Handle<v8::Array> value,
+ base::Value** out,
+ v8::Isolate* isolate,
+ const FromV8ValueCallback& callback) const override {
return false;
}
- virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
- base::Value** out,
- v8::Isolate* isolate) const override {
+ bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
+ base::Value** out,
+ v8::Isolate* isolate) const override {
return false;
}
- virtual bool FromV8Number(v8::Handle<v8::Number> value,
- base::Value** out) const override {
- return false;
- }
- virtual bool FromV8Undefined(base::Value** out) const override {
+ bool FromV8Number(v8::Handle<v8::Number> value,
+ base::Value** out) const override {
return false;
}
+ bool FromV8Undefined(base::Value** out) const override { return false; }
};
// Verify that having a strategy that fallbacks to default behaviour
« no previous file with comments | « content/renderer/v8_value_converter_impl.h ('k') | content/renderer/web_ui_extension_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698