content/renderer/skia_benchmarking_extension.h - Issue 670683003: Standardize usage of virtual/override/final in content/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/skia_benchmarking_extension.h

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/skia_benchmarking_extension.h

diff --git a/content/renderer/skia_benchmarking_extension.h b/content/renderer/skia_benchmarking_extension.h

index 716378dbcfab1fb46e6e240529dedb92f55aa469..2e0faf16d83baa4003cecf707e6debab520aac7d 100644

--- a/content/renderer/skia_benchmarking_extension.h

+++ b/content/renderer/skia_benchmarking_extension.h

@@ -28,10 +28,10 @@ class SkiaBenchmarking : public gin::Wrappable<SkiaBenchmarking> {

private:

SkiaBenchmarking();

- virtual ~SkiaBenchmarking();

+ ~SkiaBenchmarking() override;

// gin::Wrappable.

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

// Rasterizes a Picture JSON-encoded by cc::Picture::AsValue().

« no previous file with comments | « content/renderer/shared_worker_repository.h ('k') | content/renderer/speech_recognition_dispatcher.h » ('j') | no next file with comments »