Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5941)

Unified Diff: content/renderer/pepper/v8_var_converter_unittest.cc

Issue 670683003: Standardize usage of virtual/override/final in content/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/resource_creation_impl.h ('k') | content/renderer/pepper/v8object_var.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/v8_var_converter_unittest.cc
diff --git a/content/renderer/pepper/v8_var_converter_unittest.cc b/content/renderer/pepper/v8_var_converter_unittest.cc
index d935658b5d7d8a831a89473bfd342be3e09bb923..8361dd89b47aa794790ec7afd56b78d1fe17ea5b 100644
--- a/content/renderer/pepper/v8_var_converter_unittest.cc
+++ b/content/renderer/pepper/v8_var_converter_unittest.cc
@@ -50,22 +50,22 @@ void FromV8ValueComplete(const ScopedPPVar& scoped_var,
class MockResourceConverter : public content::ResourceConverter {
public:
- virtual ~MockResourceConverter() {}
- virtual void Reset() override {}
- virtual bool NeedsFlush() override { return false; }
- virtual void Flush(const base::Callback<void(bool)>& callback) override {
+ ~MockResourceConverter() override {}
+ void Reset() override {}
+ bool NeedsFlush() override { return false; }
+ void Flush(const base::Callback<void(bool)>& callback) override {
NOTREACHED();
}
- virtual bool FromV8Value(v8::Handle<v8::Object> val,
- v8::Handle<v8::Context> context,
- PP_Var* result,
- bool* was_resource) override {
+ bool FromV8Value(v8::Handle<v8::Object> val,
+ v8::Handle<v8::Context> context,
+ PP_Var* result,
+ bool* was_resource) override {
*was_resource = false;
return true;
}
- virtual bool ToV8Value(const PP_Var& var,
- v8::Handle<v8::Context> context,
- v8::Handle<v8::Value>* result) override {
+ bool ToV8Value(const PP_Var& var,
+ v8::Handle<v8::Context> context,
+ v8::Handle<v8::Value>* result) override {
return false;
}
};
« no previous file with comments | « content/renderer/pepper/resource_creation_impl.h ('k') | content/renderer/pepper/v8object_var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698